Repository navigation
Validate vehicle type references across GBFS feeds - #218
mackenziereading19 wants to merge 1 commit into
Conversation
👷 Deploy request for gbfs-validator pending review.Visit the deploys page to approve it
|
|
Hello @mackenziereading19, Thank you for contributing to the GBFS validator! Sorry for the delayed response. As explained in #217, I think that if we add object dependency relationships validation, we should do it for all objects. I will check internally with MobilityData IT team how we can help with this. Please note that this Javascript validator will progressively be replaced by this one in Java: https://github.com/MobilityData/gbfs-validator-java. Best regards, |
|
Hello @mackenziereading19, Thank you for your contribution to the JavaScript validator. As explained in #217, we want to refrain from approving PRs with partial fixes, since we won't have time to follow up and complete them. For now, I will close this PR, the conversation continues in #153. Please don't hesitate if you have any questions. Thank you! |
Fixes a subset of #217.
This adds cross-file validation ensuring
vehicle_type_idvalues infree_bike_status.json/vehicle_status.jsonresolve to IDs defined invehicle_types.json.The check is applied across supported GBFS versions v2.1, v2.2, v2.3, v3.0 and v3.1-RC3.
Existing conditional behaviour requiring
current_range_metersfor motorized vehicle types is preserved.A regression fixture demonstrates the previous false negative in GBFS v3.0, where an undefined
vehicle_type_idpassed validation without errors.Tests
This intentionally does not yet address the other cross-file ID relationships mentioned in #217, such as station, pricing-plan or geofencing references.