DEVOPS-3406 - inject required secret keys only - #3
Closed
raul-gherman-modaoperandi wants to merge 1 commit into
Closed
DEVOPS-3406 - inject required secret keys only#3raul-gherman-modaoperandi wants to merge 1 commit into
raul-gherman-modaoperandi wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
raul-gherman-modaoperandi
September 9, 2026 12:22
View session
There was a problem hiding this comment.
🟡 Changes recommended
The unsupported ESO field blocks Secret materialization and requires valid implementation and integration coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates Helm ExternalSecret handling so only boot-critical secrets are required.
Changes:
- Marks 17 non-critical secret references optional.
- Updates Helm rendering assertions.
- Documents required and optional keys.
File summaries
| File | Review |
|---|---|
packaging/helm/openwork-ee/tests/external-secrets.sh |
Rendering assertions do not validate ESO synchronization with an absent optional key. Moderate (2 votes) |
packaging/helm/openwork-ee/templates/externalsecret.yaml |
Emits unsupported remoteRef.optional, causing Kubernetes rejection. Critical (2 votes) |
packaging/helm/openwork-ee/README.md |
Documents unsupported behavior and conflicts with values.yaml guidance. Two nits (1 vote each) |
Review details
Suppressed comments (2)
packaging/helm/openwork-ee/README.md:364
- This documents
remoteRef.optionalas supported since ESO 0.5.3, but that field is absent from both the v1beta1 and v1 ExternalSecret CRD schemas. Following this guidance produces a resource Kubernetes rejects rather than a Secret with omitted keys; revise the documentation once the implementation uses a supported optional-key mechanism.
missing one fails the ExternalSecret loudly. Every other `secret.keys.*` entry
is rendered `optional: true` (requires ESO ≥ 0.5.3), so a missing optional key
(`DAYTONA_API_KEY`, `SMTP_PASS`, ...) does not block the Secret — ESO skips it
and the app reads it as unset. Key names must match `secret.keys.*` values;
packaging/helm/openwork-ee/README.md:354
- This new guidance contradicts the chart's user-facing comments in
values.yaml:246-248andvalues.yaml:266-269, which still say everysecret.keys.*entry must exist. Update those comments in this PR so operators configuring the chart do not receive mutually exclusive requirements.
# The three boot-critical keys must exist under this trunk, e.g.
# eks/openwork/prod/den/DATABASE_URL. All other keys are optional.
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+50
to
+51
| {{- if not (has $name $requiredKeys) }} | ||
| optional: true |
Comment on lines
+94
to
+96
| # Only the three boot-critical keys are required in the provider; the other 17 | ||
| # are optional so a missing optional key does not block the whole Secret. | ||
| assert_count "$enabled_rendered" 'optional: true' 17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.