perf(web): bound DOM growth in long sessions#1900
Conversation
🦋 Changeset detectedLatest commit: 27b6834 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c9156e66c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // kimi-ui: groups default to collapsed (they used to default open, mounting | ||
| // every tool call body of every past turn). A group with tools still running | ||
| // opens itself so live execution stays visible. | ||
| const open = ref(aggregateStatus.value === 'running'); |
There was a problem hiding this comment.
When an existing tool stack is initially collapsed (for example after refreshing a long session with completed tools) and a later running tool is appended to the same assistant turn, aggregateStatus updates to running but open keeps the one-time initial value from mount. Because the group body is now v-if="open", the live tool rows stay unmounted behind a collapsed header even though the new behavior intends running groups to open automatically; add a watcher/effect that sets open when the aggregate status becomes running.
Useful? React with 👍 / 👎.
- ToolOutputBlock: outputs beyond 80 lines render tail-biased behind an expand-to-full button (i18n) instead of thousands of divs - ToolRow/ToolGroup: unmount collapsible bodies when closed (they stayed mounted under grid 0fr); ToolGroup defaults to collapsed and auto-opens while tools are running - scrollKey: track output growth via line count + tail-line length instead of joining every tool output per change - drop characterData from the pane MutationObserver so per-token text updates no longer fire follow/hit-test work at delta rate
Address Codex review: open was initialized once at mount, so a stack that mounted completed (collapsed) and later gained a running tool kept the live rows unmounted. Watch aggregateStatus and reopen on transitions to running.
f243c08 to
27b6834
Compare
1 participant
Problem
In long sessions (hundreds of turns with large tool outputs) the conversation DOM grows without bound and the tab climbs past 1GB, making scrolling and streaming janky. Four compounding causes:
ToolRow/ToolGroupbodies render all their content even when visually collapsed (grid 0fr+inert), andToolGroupdefaults to open.characterDataMutationObserver — per-token text updates during streaming fire follow/hit-test work at delta rate.Changes
ToolOutputBlock: outputs beyond 80 lines render tail-biased (the last 80 lines, where errors/results live) behind an expand-to-full button (i18n keys added for en/zh).ToolRow/ToolGroup: collapsible bodies unmount when closed;ToolGroupdefaults to collapsed and auto-opens while any tool in it is still running, so live execution stays visible.output.join('').childListonly; the scroll follow is driven by the reactivescrollKeywatcher regardless.Result
Fresh-load footprint of a very long session drops dramatically (in local testing ~1.4GB → ~0.4GB range depending on history composition), and streaming no longer re-renders/fires observers at delta rate.