-
Notifications
You must be signed in to change notification settings - Fork 621
feat: guide AI to use ReadMediaFile for video analysis instead of manual frame extraction #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| "@moonshot-ai/vis-server": patch | ||
| --- | ||
|
|
||
| feat(vis): show LAN URLs when binding to 0.0.0.0 for remote control | ||
|
|
||
| When vis-server binds to 0.0.0.0 or :: (all interfaces), the startup | ||
| banner and CLI output now display the actual LAN IP addresses that | ||
| other devices on the same network can use to connect. This enables | ||
| lan-range remote control from phones, tablets, or other machines. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import { serve } from '@hono/node-server'; | ||
|
|
||
| import { createApp } from './app'; | ||
| import { hostForUrl, resolveHost, resolveKimiCodeHome, resolvePort, resolveVisAuthToken } from './config'; | ||
| import { getLocalNetworkAddresses, hostForUrl, isAllInterfaces, resolveHost, resolveKimiCodeHome, resolvePort, resolveVisAuthToken } from './config'; | ||
| import type { WebAsset } from './lib/web-asset'; | ||
|
|
||
| export interface StartVisServerOptions { | ||
|
|
@@ -18,6 +18,7 @@ export interface StartedVisServer { | |
| readonly port: number; | ||
| readonly host: string; | ||
| readonly url: string; | ||
| readonly lanUrls?: string[]; | ||
| readonly close: () => Promise<void>; | ||
| } | ||
|
|
||
|
|
@@ -36,6 +37,7 @@ export async function startVisServer( | |
| port: info.port, | ||
| host, | ||
| url: `http://${hostForUrl(host)}:${info.port}/`, | ||
| lanUrls: isAllInterfaces(host) ? getLocalNetworkAddresses(info.port) : undefined, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When binding to Useful? React with 👍 / 👎. |
||
| close: () => | ||
| new Promise<void>((done, fail) => { | ||
| server.close((err?: Error) => (err ? fail(err) : done())); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
::bindsFor
VIS_HOST=::or--host ::on an IPv6-only LAN,startVisServerconsiders the host an all-interfaces bind but this helper drops every IPv6 interface, so the new LAN access block is empty or only shows IPv4 URLs that may not connect. Include non-internal IPv6 addresses as bracketed URLs, e.g.http://[addr]:port/, when advertising an IPv6 all-interface bind.Useful? React with 👍 / 👎.