Subgraph deallocating timing change#379
Open
LindyHopperGT wants to merge 2 commits into
Open
Conversation
[Flow Graph] Consolidating Finish Flow concept and removing deinitialize instance as part of a flow asset finish. A new method has been introduced (FinishAndDeinitialize) to disambiguate.
Contributor
|
This declaration was left in FlowAsset.h and it causes a compilation error on my end. |
Contributor
Author
this would be a typo. I split the omni PR into four focused PR's by hand without the ability to compile + test them locally (because our code relies on them, and I haven't made a silo flow for PR submission, which I really should). You can view the code in the omni change #378 to see what the code should be. If you could submit fixes to this PR, that would be very helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subgraph nodes were the only flow node that was permanently disposing of instance data on Cleanup as opposed to in DeinitializeInstance.
Now subgraph nodes will cleanup their subgraph (including finishing it, etc.) but preserve the flow asset instance until the Subgraph flownode has its DeinitializeInstance called.