fix: prevent DOM XSS in text diff, Markdown preview, and regex output - #2
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Escape text in text diff, markdown preview (before applying markdown substitutions), and regex match output so pasted content cannot run as HTML/JS in the static tool page. Co-authored-by: Muki182 <Muki182@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a DOM-based XSS in the static
index.htmltool page: user-controlled text was inserted intoinnerHTMLwithout escaping in three places (text diff, Markdown preview, regex match highlights).Bug and impact
Root cause
textDiff()built HTML from line strings with${la}/${lb}unescaped.renderMD()ran markdown transforms on raw input, then assigned toinnerHTML— any<script>or event handlers in input executed.testRegex()embedded match substrings ininnerHTMLunescaped.Fix
escapeHtml()and used it for diff lines, for Markdown input (before applying the simple regex-based “markdown” rules), and for each regex match string when building the result HTML.Validation
innerHTMLwrite paths that mixed user text with markup now escape that text first.package.json/ test runner in repo; no automated tests added.