fix(security): Prevent DOM XSS in Markdown, text diff, and regex outputs - #5
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
User-controlled strings were assigned to innerHTML without escaping, allowing script injection (e.g. <img onerror=...> in Markdown preview). Add escapeHtml(), apply before Markdown transforms and for diff/regex displays. Add scripts/verify-security.mjs for regression checks. Co-authored-by: Muki182 <Muki182@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
DOM-based XSS in three client-only tools: anyone who pastes crafted text (or opens a shared snippet) could run arbitrary JavaScript in the victim’s origin. That can lead to session/token theft if the site later adds auth, malicious redirects, or defacement.
Concrete triggers
# <img src=x onerror=alert(1)>— the old pipeline injected raw HTML into#md-previewviainnerHTML.<img src=x onerror=alert(1)>was concatenated into diff HTML unchanged.innerHTMLunescaped.Root cause
User input (or match substrings / error messages) was interpolated into template strings assigned to
element.innerHTMLwithout HTML entity encoding.Fix
escapeHtml()and use it before Markdown regex transforms (markdown syntax still works; angle brackets in content are neutralized).textDiff()and match / error strings intestRegex().Validation
node scripts/verify-security.mjs(assertsescapeHtmlbehavior and thatindex.htmlcontains the expected guard patterns).