Skip to content

Move actual key store into Mock BPA#247

Open
BrianSipos wants to merge 13 commits into
mainfrom
245-keystore-api
Open

Move actual key store into Mock BPA#247
BrianSipos wants to merge 13 commits into
mainfrom
245-keystore-api

Conversation

@BrianSipos

Copy link
Copy Markdown
Collaborator

This resolves #245 by moving the demo key store into the Mock BPA proper and providing a key store callback interface in the crypto library.

@BrianSipos BrianSipos added this to the BSL v2.0.0 milestone Jul 16, 2026
@BrianSipos BrianSipos self-assigned this Jul 16, 2026
@BrianSipos BrianSipos added this to BSL Jul 16, 2026
@github-project-automation github-project-automation Bot moved this to Todo in BSL Jul 16, 2026
@BrianSipos BrianSipos changed the title Checkpointing working config Move actual key store into Mock BPA Jul 16, 2026
@BrianSipos BrianSipos moved this from Todo to In Progress in BSL Jul 16, 2026
@BrianSipos

Copy link
Copy Markdown
Collaborator Author

This is a somewhat messy refactoring, so I expect that several symbol names will need to be fixed after moving things around.

@BrianSipos

Copy link
Copy Markdown
Collaborator Author

@250MHz as of now, the callback interface in bsl/crypto/KeyStore.h is for the crypto functions reading key info but not modifying it. If there is value in moving the JWK Set and COSE_KeySet readers into the common crypto library, the callbacks can be augmented for adding key and setting key parameter.

@sonarqubecloud

Copy link
Copy Markdown

@BrianSipos
BrianSipos marked this pull request as ready for review July 17, 2026 17:55
@BrianSipos
BrianSipos requested a review from a team as a code owner July 17, 2026 17:55
@250MHz

250MHz commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

If there is value in moving the JWK Set and COSE_KeySet readers into the common crypto library, the callbacks can be augmented for adding key and setting key parameter.

I think BPAs would find that helpful, but might be nicer from BSL's POV for the readers to be in a separate library from libbsl_crypto?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Need a SW-crypto key store interface to allow persistence

2 participants