Skip to content

[repository.yaml] Metadata errors: self-referential changelog and inconsistent/stale extent conventions #71

Description

@bdestombe

Severity: nit (registry is informational, not consumed programmatically)

Where: src/nhflodata/data/repository.yaml (~L197 and the extent fields).

Problem. The bodemlagen_pwn_regis_koppeltabel v1.1.0 entry lists its own version (1.1.0) as previous_version; and the extent fields mix two coordinate-order conventions and are stale for lakes_pwn, making the registry unreliable as documentation.

Suggested fix. Fix previous_version to 1.0.0, standardize extent on one documented convention (suggest nlmod's xmin,xmax,ymin,ymax), and regenerate stale extents from the actual files.


From a systematic review of modelscripts/09pwnmodel2/01_pwnmodel2.py and its dependency stack (nhflotools, nhflodata, nlmod), July 2026. Every finding was traced through the actual code and adversarially verified before filing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions