Draft
Restore ITK4/ITK5 compatibility in Testing/itkTestMain.h threading setup#94
Testing/itkTestMain.h threading setup#94Conversation
Copilot
AI
changed the title
[WIP] Fix code according to review comment
Restore ITK4/ITK5 compatibility in Jul 23, 2026
Testing/itkTestMain.h threading setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review comment flagged that
itkTestMain.hhad moved to an ITK5-only threading API while this repository still targets ITK4 in build configuration. This updates the test driver to compile against both ITK4 and ITK5 without changing project-wide ITK requirements.Compatibility fix
Testing/itkTestMain.h:itkMultiThreaderBase.h/itk::MultiThreaderBaseitkMultiThreader.h/itk::MultiThreaderitk::MultiThreadercalls with a single compatibility alias.Behavioral scope
--with-threads,--without-threads); only API selection at compile time was adjusted.