Skip to content

cuequivariance signing - #52

Merged
ohadmo merged 5 commits into
mainfrom
fix/cuequivariance-skills
Oct 6, 2026
Merged

ohadmo merged 5 commits into
mainfrom
fix/cuequivariance-skills

Conversation

@ohadmo

@ohadmo ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo ohadmo changed the title fix layout guidance and add validated examples cuequivariance signing Oct 2, 2026
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

@greptileai

@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low risk] Adds documentation and tests for a math library skill.

The PR appears safe to merge, with a non-blocking correction needed to the skill card’s credential metadata.

Findings

  1. P2 Ambiguous credential requirement ▶

Summary

The PR reorganizes the cuEquivariance skill into focused references, adds CPU example tests and CI, and updates its benchmark, skill card, and signing bundle.

  • The updated benchmark reports a publication PASS.
  • The skill card leaves a credential-free workflow’s requirement unspecified.

Reviews (5) · Last reviewed commit: "Attach NVSkills validation signatures"

Comment thread library-skills/cuequivariance/references/ir-dict.md
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo
ohadmo force-pushed the fix/cuequivariance-skills branch from 6137cc7 to fa09665 Compare October 2, 2026 18:32
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Comment thread skills/bionemo-agent-toolkit/skills/cuequivariance/BENCHMARK.md Outdated
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Comment on lines +18 to +19
**Requires API Key or External Credential:** [Not Specified] <br>
**Credential Type(s):** [None identified] <br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Ambiguous credential requirement The skill runs locally without an API key, but [Not Specified] leaves users unsure whether credentials are needed. The repository’s other credential-free library skill uses [No] and [None]; using those values here would keep the card clear and consistent.

Suggested change
**Requires API Key or External Credential:** [Not Specified] <br>
**Credential Type(s):** [None identified] <br>
**Requires API Key or External Credential:** [No] <br>
**Credential Type(s):** [None] <br>

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@ohadmo
ohadmo merged commit 2113472 into main Oct 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants