refactor(audio): split Sortformer and Silero VAD into stage adapters - #2455
Draft
mohammadaaftabv wants to merge 3 commits into
Draft
mohammadaaftabv wants to merge 3 commits into
mohammadaaftabv wants to merge 3 commits into
Conversation
Signed-off-by: V Mohammad Aaftab <aaftaabv@gmail.com>
Contributor
|
🌿 Preview your docs: https://nvidia-preview-agent-sortformer-silero-adapters.docs.buildwithfern.com/nemo/curator Here are the markdown pages you've updated: |
Signed-off-by: V Mohammad Aaftab <aaftaabv@gmail.com>
Signed-off-by: V Mohammad Aaftab <aaftaabv@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves Sortformer diarization and Silero VAD to the shared stage/adapter architecture already used by ASR and SED.
DiarizationAdapterandVADAdaptercontracts.AdapterInferenceStagefor node prefetch, worker setup, GPU allocation, and teardown.AudioDataFilterStage.TensorRT Sortformer and Silero support is intentionally split into follow-up draft #2457.
Compatibility
Documentation scope
The in-repository audio developer READMEs and tutorials are updated for the adapter boundary and output contract. This PR contains no Fern changes.
Validation
190 passed, 1 warning.80 passed.git diff --checkpassed.main: zero files.Local parity
A frozen local target/reference experiment ran the PR head (
3aa1b4a1cab24d83710f70e4a8fc0779339d4650) againstnithinraok/Curator:nkoluguri/integration-test(1e2d639946f28dfd289a0a9456480385d4480c28) on one RTX 3080 Ti. Both arms used the same two original whole-recording AMI WAVs, model, dependency environment, resource contract, and comparator.2a773e80-00f1-4bab-b5c6-edb0e7a186f1(SUCCEEDED).fda2fef9-6d9a-4292-bfd0-68c7ff4fd9d3(SUCCEEDED).0.0 ms; total-speech delta0.0 ms.0.0 ms; pseudo-DER0.0; speaker cardinality4/4for both recordings.Earlier environment-only failures are preserved in the local evidence. The successful replacement pair corrected the Ray/NVML harness without changing either Curator source tree, feature configuration, model, inputs, backend, hardware, comparator, or acceptance thresholds.