docs(slurm): add public workflow and release checks - #939
andreatnvidia wants to merge 8 commits into
Conversation
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
|
Fern preview: https://nvidia-preview-pr-939.docs.buildwithfern.com/nemo/datadesigner
|
|
Nice work on this one, @andreatnvidia — the public workflow and release hardening fit together cleanly. SummaryThis adds the full public Fern workflow for the Slurm extension, keeps the shipped examples synchronized with the guide, removes the unsupported FindingsNo blocking findings. What Looks Good
Residual RiskI could not independently complete the end-to-end wheel-install check because PyPI egress was unavailable in the isolated review environment. I reviewed that script in full and independently verified the Fern links, documented-example synchronization, public-artifact audit, formatting/lint, all 129 changed test slices, and 1,667 source-level Slurm tests; the remaining package-registration assertion requires installed wheel metadata. VerdictShip it — ready to merge as-is. This review was generated by an AI assistant. |
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
Follow-up validation: I ran a clean-room documentation exercise with an agent that had no prior Data Designer Slurm implementation context. I provided only the cluster access instructions and operating rules, including using Slurm for compute, avoiding substantive work on the login node, and limiting the test to one GPU. The agent followed the public workflow from environment and profile setup through image registration, dry-run, submission, status inspection, and result verification. The iterations produced the following material corrections:
The first runtime failure also showed that allocation-level errors did not provide enough durable context. After those corrections, I rebuilt the packages from the exact branch commit, installed them into a fresh client image, and repeated the workflow. The one-GPU, one-record vLLM run completed successfully: the endpoint became ready, the attempt succeeded, the winner was published, and the canonical manifest identified exactly one output row containing the expected smoke marker. The clean-room findings and resulting corrections span |
📋 Summary
Publish the complete public Fern workflow for Data Designer Slurm and tighten the package release checks that keep the optional extension installable, isolated, and consistent with the documented examples. This closes the documentation and release-integration slice without claiming the formal sealed-cluster acceptance owned by #870.
🔗 Related Issue
Closes #874
Formal sealed-artifact and real-cluster acceptance remains in #870. It follows after this PR merges and any required fixes land.
🔄 Changes
✨ Added
🔧 Changed
🐛 Fixed
execute --forcepath from the CLI and public run-service API while preserving force handling where retry and benchmark workflows support it.🔍 Attention Areas
forceargument from execution.🧪 Testing
make check-slurmmake test-slurm- 1672 passedmake test-slurm-wheel-installmake check-fern-linksmake check-fern-docs- 0 errors, 1 pre-existing hidden-page warning.venv/bin/ruff check --fix . && .venv/bin/ruff format .✅ Checklist