feat(eval): check selected attempts in rollout health reports - #3881
Draft
yuhezhang-ai wants to merge 1 commit into
Draft
yuhezhang-ai wants to merge 1 commit into
yuhezhang-ai wants to merge 1 commit into
Conversation
This was referenced Oct 1, 2026
yuhezhang-ai
force-pushed
the
yuhez/2135-rollout-recovery
branch
from
October 2, 2026 02:53
21e6b99 to
6e69afe
Compare
yuhezhang-ai
force-pushed
the
yuhez/2135-recovery-health
branch
3 times, most recently
from
October 2, 2026 16:25
9eb9066 to
a391a53
Compare
Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
yuhezhang-ai
force-pushed
the
yuhez/2135-recovery-health
branch
from
October 2, 2026 17:02
a391a53 to
bc7eef6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make health reports inspect the same completed attempts that evaluation scoring selects. If a newer attempt failed or was interrupted, an older saved success must not reappear as a healthy completed sample.
Extracted from #3302 as a separate follow-up to #2135. Depends on #3302; this draft targets its branch. Judge-only recovery is the independent sibling draft #3879.
Validation
Rebased onto #3302
5cd78777c. Final follow-up head:bc7eef604.pytest tests/unit_tests/test_{journal_health,rollout_health,rollout_journal,rollout_store,rollout_collection,rollout_outcomes,cli_eval}.py -q --tb=short— 671 passed.pre-commit run --all-filesandcd fern && npm run check— passed (Fern: zero errors, one warning).5cd78777cfetched server configuration over HTTP with no local server blocks.Rollouts
This changes artifact reading, not agent execution or verifier scoring. The earlier read smoke at
9eb9066f5used actual Qwen2.5-0.5B outputs from Gym's production model adapters, Simple Agent, FrontierScience verifier, and legacy Environment Server adapter. Those runs exercised SIGKILL/resume with interrupted file tails, a judge outage, and whole-task retries.Earlier combined evidence at
87048b331enabled automatic health during SIGKILL/resume and judge-only recovery, with three selected records and no read or duplicate-identity errors. That combined inference smoke was not repeated for this rebase. Capture-dependent checks remain unobserved because these smoke runs have no trajectory captures; this is recovery evidence, not benchmark-quality or training evidence.Compatibility and benchmark impact
Removes #3302's temporary guard against journal-backed health reads. Health sample counts and findings may change for histories containing superseded attempts; they now describe the selected completed results. Evaluation rewards, aggregation rules, saved trajectories, and training behavior are unchanged.
Checklist