Conversation
macandro96
force-pushed
the
amahishi/gym-turn-recovery-orchestration
branch
from
September 29, 2026 03:42
4db8f66 to
7ebf4aa
Compare
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
force-pushed
the
terryk/rl-1581-cpu-mocks
branch
from
September 29, 2026 20:15
d61ee61 to
1e7c0cb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds replaceable CPU policy, generation, and refit components under
tests/mock_stack/to exercise the real Single Controller, Gym, token capture, row assembly, and SimpleStorage recovery path without GPUs. Production recovery code is unchanged.The test runs four prompt groups with three siblings each, saves at steps 2 and 4, removes step 4, starts a fresh Ray runtime, and restores step 2 through normal discovery. It checks training order, reuse of one completed sibling, continuation of five partial siblings, exactly 20 new model calls, exact saved token/logprob prefixes, and restored policy weights.
Issues
Depends on #4266 and targets its branch. Draft for viewing the additional test diff.
Usage
See
tests/mock_stack/README.mdfor the workload, component factories, and environment requirements.Validation
Before ready for review
Additional information
Rollout timing uses elapsed sleeps, with no event gates. The assertions fail when the expected checkpoint cut is missed. The first version uses deliberate checkpoints and normal shutdown; signal/crash injection and mixed real/GPU components are outside this test's scope.
Per-call timing records are currently returned in memory, not saved as an observed-timeline artifact. Existing text logs alone cannot reconstruct the complete rollout timeline.