Skip to content

feat(checkpoint): support sharded generation-prefix recovery - #4323

Open
macandro96 wants to merge 3 commits into
amahishi/prefix-recovery-sharded-gymfrom
amahishi/prefix-recovery-sharded-prefix
Open

macandro96 wants to merge 3 commits into
amahishi/prefix-recovery-sharded-gymfrom
amahishi/prefix-recovery-sharded-prefix

Conversation

@macandro96

@macandro96 macandro96 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • export each Gym shard's active generation-cut index
  • validate that every prepared shard contributes one digest-bound cut fragment
  • union peer cut indexes into one authoritative shared policy-model ledger commit
  • restore sharded generation prefixes while preserving shard-local agent/resource state
  • add sharded prefix recovery and failure-path coverage

Stack

Validation

  • ruff check and ruff format --check passed on the final stack
  • Python compilation passed for the checkpoint orchestration modules
  • the two-shard prefix-recovery functional test still needs to run on the cluster

@copy-pr-bot

copy-pr-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Sep 29, 2026
@github-actions

Copy link
Copy Markdown

❌ Submodule Fast-Forward Check Failed

Check based on commit: a058431 (PR #4323 from amahishi/prefix-recovery-sharded-prefix)

❌ Submodules that need attention:

Gym: ❌ Commits have DIVERGED from a common ancestor
TARGET (amahishi/prefix-recovery-sharded-gym branch): https://github.com/NVIDIA-NeMo/Gym/commits/e95d57f7d91af426a17336a1ae03398d42de0479/
CURRENT (PR #4323 from amahishi/prefix-recovery-sharded-prefix): https://github.com/NVIDIA-NeMo/Gym/commits/126a8adcbb2a90e42d5681bf99ccbe2bc2e54497/

Please ensure all submodule commits are fast-forwards of the amahishi/prefix-recovery-sharded-gym branch before merging.

@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 36b14b2 (PR #4323 from amahishi/prefix-recovery-sharded-prefix)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of amahishi/prefix-recovery-sharded-gym branch (fast-forward)

All submodule changes look good! ✨

@macandro96
macandro96 added this pull request to stack #4267 September 29, 2026 04:25
@macandro96
macandro96 marked this pull request as ready for review September 29, 2026 04:29
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
@macandro96
macandro96 force-pushed the amahishi/prefix-recovery-sharded-prefix branch from 36b14b2 to e98b65c Compare September 29, 2026 04:45

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant