feat(classifier): add judge image input controls - #790
Draft
ayushag-nv wants to merge 5 commits into
Draft
ayushag-nv wants to merge 5 commits into
ayushag-nv wants to merge 5 commits into
Conversation
Signed-off-by: ayushag <ayushag@nvidia.com>
Signed-off-by: ayushag <ayushag@nvidia.com>
Signed-off-by: ayushag <ayushag@nvidia.com>
|
Signed-off-by: ayushag <ayushag@nvidia.com>
Signed-off-by: ayushag <ayushag@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Capability and custom classifiers already pass images from selected messages to vision-capable judges. They lacked an independent image limit for the judge, so clients could not configure text-only judging while preserving images for the answer model. Tracks SWITCH-1542.
What
judge_max_imagesto capability/custom classifiers, shared runner configuration, and Python bindings. Unset preserves current behavior;0omits judge images;Nkeeps the newest N in order.How
Select messages by reference, then copy only content retained for the judge. Share the image budget across selected messages and nested tool results. Replace omitted images with text markers to keep image-only messages valid. Reuse existing custom prompts, verdict validation, model selection, and fallback behavior. Escalation mode rejects the image option.
Where to Start Review
Start with
TaskInputandcopy_judge_blockincrates/libsy/src/algorithms/llm_class.rs, then the shared runner wiring and server payload-preservation test.examples/vision_judge/README.mddocuments reproduction and observed results.Test Plan
The live checks establish integration behavior. Cosmos produced unreliable rationales in some cases; judge accuracy is not established. Judge-specific resizing/payload budgets, finer image selection, image-aware affinity, and per-target vision checks remain follow-on work. Route-level vision declarations already exist.