hi ITN: add math operations and telephone extensions - #485
Open
mayuris-00 wants to merge 2 commits into
Open
mayuris-00 wants to merge 2 commits into
mayuris-00 wants to merge 2 commits into
Conversation
Signed-off-by: Mayuri S <mayuris@nvidia.com>
mayuris-00
marked this pull request as ready for review
September 11, 2026 03:50
mgrafu
reviewed
Sep 11, 2026
| नौ आठ सात छह~९८७६ | ||
| दो पाँच पाँच डॉट एक छह आठ डॉट चार छह डॉट एक सात पाँच~255.168.46.175 | ||
| दो पाँच डॉट दो तीन तीन डॉट एक चार डॉट दो तीन एक~25.233.14.231 | ||
| नौ आठ सात छह पाँच चार तीन दो एक शून्य एक्सटेंशन एक दो तीन~९८७६५४३२१० ext. १२३ |
Collaborator
There was a problem hiding this comment.
would it make sense to add these test cases?
चालीस पचास~४० ५०
साठ सत्तर~६० ७०
पचास पचास~५० ५०
पैंतीस पैंतालीस~३५ ४५
सत्तर अस्सी~७० ८०
अस्सी नब्बे~८० ९०
नब्बे पचास~९० ५०
चालीस पचास साठ~४० ५० ६०
पचास साठ सत्तर~५० ६० ७०
चालीस पचास साठ सत्तर~४० ५० ६० ७०
वहाँ चालीस पचास लोग थे~वहाँ ४० ५० लोग थे
स्कोर साठ सत्तर रहा~स्कोर ६० ७० रहा
अस्सी नब्बे प्रतिशत~८० ९० प्रतिशत
उसकी उम्र पैंतीस चालीस साल है~उसकी उम्र ३५ ४० yr है
नौ आठ सात छह~९८७६
इक्यासी दस इकसठ सड़सठ शून्य आठ~८११०६१६७०८
Author
There was a problem hiding this comment.
Only the last two look like telephone cases to me, and both are already in the file. The rest read as cardinal, or measure in the case of उसकी उम्र पैंतीस चालीस साल है~उसकी उम्र ३५ ४० yr है, since nothing in their expected output is phone shaped. Shall I move them to test_cases_cardinal.txt and test_cases_measure.txt?
Collaborator
There was a problem hiding this comment.
let's drop the last two, add the yr one to measures and the rest to cardinals. they might still fail because of the telephone logic!
mgrafu
reviewed
Sep 11, 2026
Signed-off-by: Mayuri S <mayuris@nvidia.com>
mayuris-00
force-pushed
the
hi-itn-math-telephone-ext
branch
from
September 15, 2026 11:55
d61766d to
1419fec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.