Skip to content

De ITN: decouple cardinal grammar from TN #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgrafu merged 13 commits into from
Sep 17, 2026
Merged

De ITN: decouple cardinal grammar from TN #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
51e2d2b
De ITN: decouple cardinal grammar from TN
adelina23dunina Sep 11, 2026
ad13453
De ITN: split regular and irregular teens
adelina23dunina Sep 14, 2026
df35324
De ITN: address review comments on cardinal grammar
adelina23dunina Sep 14, 2026
5921ed5
De ITN: address review comments on cardinal grammar
adelina23dunina Sep 14, 2026
e6abccb
De ITN: address review comments on cardinal grammar
adelina23dunina Sep 14, 2026
c5130fa
De ITN: address review comments on cardinal grammar
adelina23dunina Sep 14, 2026
4476e99
De ITN: fix cardinal tagger bugs and extend test coverage
adelina23dunina Sep 15, 2026
512f2ec
De ITN: align copyright year in de ITN utils
adelina23dunina Sep 15, 2026
6fb8682
De ITN: move the cardinal conjunction into a tsv file
adelina23dunina Sep 15, 2026
3d8e076
De ITN: make the cardinal conjunction optional via closure
adelina23dunina Sep 15, 2026
8c61318
De ITN: split a conjunction after a magnitude word, extend tests
adelina23dunina Sep 16, 2026
7fe42bc
De ITN: unify the cardinal negative field on the minus sign
adelina23dunina Sep 16, 2026
c175854
De ITN: drop redundant comments from the cardinal tagger
adelina23dunina Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ pipeline {
}
environment {
AR_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/06-11-26-0'
DE_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/10-23-24-0'
DE_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/09-11-26-0'
EN_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/06-11-26-1'
ES_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/09-25-24-0'
ES_EN_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/08-30-24-0'
Expand Down
13 changes: 13 additions & 0 deletions nemo_text_processing/inverse_text_normalization/de/data/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Copyright (c) 2026, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
13 changes: 13 additions & 0 deletions nemo_text_processing/inverse_text_normalization/de/data/cardinal/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Copyright (c) 2026, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
1 change: 1 addition & 0 deletions nemo_text_processing/inverse_text_normalization/de/data/cardinal/conjunction.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
und
13 changes: 13 additions & 0 deletions nemo_text_processing/inverse_text_normalization/de/data/cardinal/digits.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
eine 1
eins 1
ein 1
einer 1
zwei 2
zwo 2
drei 3
vier 4
fünf 5
sechs 6
sieben 7
acht 8
neun 9
3 changes: 3 additions & 0 deletions nemo_text_processing/inverse_text_normalization/de/data/cardinal/irregular_teens.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
zehn 10
elf 11
zwölf 12
7 changes: 7 additions & 0 deletions nemo_text_processing/inverse_text_normalization/de/data/cardinal/regular_teens.tsv
View file
Open in desktop
Comment thread
mgrafu marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
dreizehn 13
vierzehn 14
fünfzehn 15
sechzehn 16
siebzehn 17
achtzehn 18
neunzehn 19
8 changes: 8 additions & 0 deletions nemo_text_processing/inverse_text_normalization/de/data/cardinal/tens.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
zwanzig 2
dreißig 3
vierzig 4
fünfzig 5
sechzig 6
siebzig 7
achtzig 8
neunzig 9
1 change: 1 addition & 0 deletions nemo_text_processing/inverse_text_normalization/de/data/cardinal/zero.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
null 0
Loading