feat(en): expand Unicode symbol normalization - #490
Open
HungerDeng wants to merge 2 commits into
Open
HungerDeng wants to merge 2 commits into
HungerDeng wants to merge 2 commits into
Conversation
Expand English normalization coverage for mathematical operators, currency signs, micro units, and common standalone symbols. Categorize each symbol under the grammar that matches its meaning. Signed-off-by: hungerdeng <hungerdeng@gmail.com>
Exercise the added math operators, micro-sign units, currency symbols, and whitelist symbols in the shared English fixtures used by pytest and Sparrowhawk. Signed-off-by: hungerdeng <hungerdeng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand English text normalization for common Unicode math operators, currency symbols, micro-sign units, and general symbols, referencing the text replacement of the https://github.com/espeak-ng/espeak-ng/blob/master/dictsource/en_emoji
Changes
≤,≦,≥, and≧.Testing
python -m pytest -q tests/nemo_text_processing/en/test_math.py tests/nemo_text_processing/en/test_measure.py tests/nemo_text_processing/en/test_money.py tests/nemo_text_processing/en/test_whitelist.py --cpu --use_local_test_data --tn_cache_dir=/private/tmp/nemo_tn_cache(492 passed).${VAR,,}syntax.Notes for Reviewers
The distinct Unicode multiplication aliases (
×,*,·,∗,∙, and⋅) intentionally remain mapped totimesinmath_operation.tsv; they are different input code points.