Add unified results for single-sbatch Slurm scenarios - #1041
Draft
podkidyshev wants to merge 1 commit into
Draft
podkidyshev wants to merge 1 commit into
podkidyshev wants to merge 1 commit into
Conversation
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
podkidyshev
added this pull request to stack #1042
September 18, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
experiment.json, with workload status and canonical metrics. Previously single-sbatch output contained only scenario-level information.was_run_successful; allocation-wide status and timing are not applied to every case.Test Plan
Affected tests on macOS / Python 3.14.3:
All pre-commit checks passed for the four changed files. Existing completion and trajectory tests were extended to cover per-case metrics/timing, failure/cancellation, missing execution evidence, and DSE selection; no new test functions were added.
A live single-sbatch test on one eight-H100 node ran a normal NCCL case and a two-point NCCL algorithm sweep. All three executions passed. Downloaded artifacts were analyzed locally using the workload success and canonical metric methods:
Ring), matching the trajectory's highest configured inverse-latency reward.Additional Notes
Stack: #1030 (
ipod/unified-output→main) → #1040 (ipod/unified-slurm→ipod/unified-output) → this PR (ipod/slurm-api-ssbatch→ipod/unified-slurm).Live progress, iteration aggregation, and DSE with iterations remain separate work.