Accept post-release wheel versions in release validation#2178
Open
fallintoplace wants to merge 1 commit into
Open
Accept post-release wheel versions in release validation#2178fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-release-wheels.postNversions from release tags instead of truncating toX.Y.Zv12.6.2.post1wheel validationWhy
Post-release tags such as
v12.6.2.post1were parsed as12.6.2, so valid wheels likecuda_bindings-12.6.2.post1-...whlfailed release validation before upload or publishing.Testing
uvx pytest --confcutdir=ci/tools/tests ci/tools/tests/test_validate_release_wheels.py ci/tools/tests/test_check_release_notes.pyuvx ruff check ci/tools/validate-release-wheels ci/tools/tests/test_validate_release_wheels.pyuvx ruff format --check ci/tools/validate-release-wheels ci/tools/tests/test_validate_release_wheels.py./ci/tools/validate-release-wheels v12.6.2.post1 cuda-bindings <tmp-wheel-dir>