Skip to content

fix: clarify invalid container root errors #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henry118 merged 1 commit into from
Oct 1, 2026
Merged

fix: clarify invalid container root errors #2116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cmd/nvidia-cdi-hook/update-ldcache/update-ldcache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,11 @@ func (m command) run(_ *cli.Command, cfg *options) error {
}

containerRootDir, err := s.GetContainerRoot()
if err != nil || containerRootDir == "" || containerRootDir == "/" {
return fmt.Errorf("failed to determined container root: %v", err)
if err != nil {
return fmt.Errorf("failed to determine container root: %w", err)
}
if containerRootDir == "" || containerRootDir == "/" {
return errors.New("failed to determine container root: invalid root")
}

runner, err := ldconfig.NewRunner(
Expand Down
Loading