Conversation
Sscanf counted a match before the rest of the token was checked, so gpu0/gi0/accessEXTRA was stored as a capability. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
SashaMIT
requested review from
cdesiniotis,
henry118 and
tariq1890
as code owners
September 30, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minors line
gpu0/gi0/accessEXTRA 3was accepted as capabilitygpu0/gi0/accessEXTRAwith minor 3.gpu0/gi0/ci0/accessEXTRA 4was accepted the same way.fmt.Sscanfreports a match as soon as the indexes are read, so the rest of the token never had to be empty.The check now rebuilds
gpuN/giN/accessorgpuN/giN/ciN/accessand requires that text to be the whole token.gpu0/gi0/access 3,gpu0/gi0/ci0/access 4,config, andmonitorstay valid.Drafted with Grok 4.7. The code has not yet been reviewed by a human.