Skip to content

fix(read_env): only advertise inline_completion for set_value_t #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nebkat wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix(read_env): only advertise inline_completion for set_value_t #2112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions include/stdexec/__detail/__read_env.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,14 @@ namespace STDEXEC
template <class _Query>
struct __attrs
{
template <class _SetTag>
STDEXEC_ATTRIBUTE(nodiscard)
constexpr auto query(__get_completion_behavior_t<_SetTag>) const noexcept
constexpr auto query(__get_completion_behavior_t<set_value_t>) const noexcept
Comment thread
nebkat marked this conversation as resolved.
{
return __completion_behavior::__inline_completion;
}

STDEXEC_ATTRIBUTE(nodiscard)
constexpr auto query(__get_completion_behavior_t<set_error_t>) const noexcept

@ericniebler ericniebler Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be constrained on whether the query expression is potentially throwing.

{
return __completion_behavior::__inline_completion;
}
Expand Down