Removed auto-register and made players require to set a password - #52
Draft
ThomasWega wants to merge 3 commits into
Draft
Removed auto-register and made players require to set a password#52ThomasWega wants to merge 3 commits into
ThomasWega wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done to fix a crucial issue I encountered. Cracked players with nicknames that are already existing on a premium user were not able to join at all and always gotten invalid session message. This was caused by this specific part
This led me to realize there are only two options at this point
I am much more comfortable with option number 2 and that is what this PR accomplishes.
The reason this is a draft is because I feel like this should be a switch as is with other auth plugins. I'm looking for feedback how to implement that nicely