You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the first pull request here. CI needs a maintainer to approve the run before it starts, so it may sit for a bit before anything happens. pytest tests/ -q passing is the main thing I look at.
Thanks for taking all 33. Two things before this can go in.
1. en.json was re-serialized. The 33 new keys are about 35 lines, but the diff is 294 because the whole file went through a JSON writer: … and · became escape sequences and the compact one-line objects were expanded. That makes the file harder for translators to read and the PR hard to review. Please restore en.json from main and add only the new keys, by hand, next to the keys they belong with.
2. The other nine locales need the same keys. CI fails in frontend/scripts/test-i18n-keys.mjs, which requires every file in frontend/src/messages/ to have identical keys. The issue told you English was enough; that was my mistake and the issue text is fixed now. Real translations where you can, the English text where you cannot.
Smaller: the keys are all under a flat component.*. The existing ones are grouped by where they are used, topbar.* and results.*, and #444 adds aria-labels for some of the same Topbar buttons. Reusing its topbar.* keys where the text is identical saves you a few.
cd frontend && npm run test:i18n confirms the locales line up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #437 by migrating all hardcoded English tooltips to the i18n translation system.
Changes
titleattributes fromcomponents/Topbar.tsxtitleattributes fromcomponents/views/ScanResults.tsxcomponentnamespace inmessages/en.jsont('component.key')andi18n('component.key')respectivelyType of change
Testing
Screenshots
N/A (No visual changes, purely internationalization)