Enforce upload size limit on /api/metadata body and harden Content-Length parsing - #449
Merged
Merged
Conversation
|
Thanks for the first pull request here. CI needs a maintainer to approve the run before it starts, so it may sit for a bit before anything happens. |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #448
Problem
/api/metadata only checked the Content-Length header for upload size, so chunked uploads without that header could exceed the limit. Additionally, check_upload_size raised an unhandled ValueError (500) on non-numeric or negative Content-Length values.
Fix
Replaced the unbounded shutil.copyfileobj in the /api/metadata spool step with a chunked read that raises 413 once MAX_UPLOAD_BYTES is exceeded and removes the partial temp file on failure. Made check_upload_size return HTTP 400 for non-numeric or negative Content-Length instead of propagating ValueError.
Tests
tests/test_upload_size_guard.pythat fails before this change and passes after it.