[fix][train] Defer W&B authentication to SDK - #2005
Open
bvolpato wants to merge 2 commits into
Open
Conversation
bvolpato
force-pushed
the
bvolpato/wandb-netrc-auth
branch
2 times, most recently
from
August 10, 2026 01:07
d53a8ab to
cb05331
Compare
This was referenced Aug 10, 2026
bvolpato
force-pushed
the
bvolpato/wandb-netrc-auth
branch
from
August 13, 2026 01:21
cb05331 to
f74da0a
Compare
bvolpato
marked this pull request as ready for review
August 13, 2026 01:23
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes explicit checks for the WANDB_API_KEY environment variable in validate_generator_cfg and WandbTracker, deferring authentication directly to the wandb library. Unit tests have been added to ensure that the configuration validation and tracker initialization succeed even when the environment variable is not set. I have no feedback to provide as the changes are clean and well-tested.
bvolpato
force-pushed
the
bvolpato/wandb-netrc-auth
branch
from
August 14, 2026 04:39
f74da0a to
5c12e97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkyRL checked only
WANDB_API_KEYbefore calling W&B. That rejected credentials stored bywandb loginand offline runs that do not need API access. It also replaced W&B's authentication errors with a less useful SkyRL assertion.Changes
WandbTracker.wandb.initselect and validate supported authentication modes.WANDB_API_KEYbehavior remains unchanged. Netrc and offline authentication now follow standard W&B SDK behavior.Validation
147 passed)WandbTrackerwithoutWANDB_API_KEYpre-commit run --all-filesgit diff --check upstream/main