Skip to content

Remove unused configuration, scripts, and workflows - #2950

Merged
deepakunni3 merged 3 commits into
OBOFoundry:masterfrom
cthoyt:cleanup-unused-scripts
Sep 29, 2026
Merged

deepakunni3 merged 3 commits into
OBOFoundry:masterfrom
cthoyt:cleanup-unused-scripts

Conversation

@cthoyt

@cthoyt cthoyt commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

This PR removes several missing/unused components:

  1. It gets rid of requirements.txt. Each script now uses PEP 723 inline metadata to more narrowly define its own requirements and has a shebang that says to run it with uv run when invoked as a script
  2. Removes commands from the makefile that refer to scripts that don't exist anymore (there's no reboot.sh nor utils/principles folder)
  3. Removes build.sh which was just for setting up a legacy virtual env, see point 1

@cthoyt
cthoyt requested a review from deepakunni3 September 18, 2026 13:39
@cthoyt
cthoyt force-pushed the cleanup-unused-scripts branch from 45681c3 to 5250b16 Compare September 18, 2026 15:08
Comment thread .github/workflows/obo-test.yml Outdated
@cthoyt cthoyt added attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools python Pull requests that update Python code labels Sep 25, 2026
@cthoyt
cthoyt force-pushed the cleanup-unused-scripts branch from a6fd898 to 0d336fa Compare September 27, 2026 18:08
@cthoyt

cthoyt commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator Author

@matentzn would appreciate a quick look at this, shouldn't be controversial, just removes some unused things

@jsstevenson

jsstevenson commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

looks great for now; I think a uv lockfile might be in order at some point but probably won't ever matter

@jsstevenson
jsstevenson self-requested a review September 29, 2026 15:11
@deepakunni3
deepakunni3 merged commit 5e53eb5 into OBOFoundry:master Sep 29, 2026
2 checks passed
@cthoyt
cthoyt deleted the cleanup-unused-scripts branch September 29, 2026 15:54
@cthoyt

cthoyt commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

thanks @jsstevenson @deepakunni3.

the dependabot update in #2953 broke the metadata rebuild workflow: https://github.com/OBOFoundry/OBOFoundry.github.io/actions/runs/36592538989

however, now that this is merged, the root cause is gone.

could one of you re-trigger the metadata rebuild action so the results from #2951 get incorporated into the export YAML file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants