Conversation
5a94f96 to
b0d63bf
Compare
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Code review LGTM!
|
@robyf70 could you please squash the administrative and bot commits? |
|
This PR has the |
@BhaveshHeliconia Sure, but how I can do that? |
[UPD] Update maintenance_equipment_hierarchy.pot
…ake field translatable
…ads wrongly to parent equipment
…nt_path as proposed by warning logs
b0d63bf to
128e3f5
Compare
|
@robyf70 review new commit history, it seems that you've make more squashs than required. The goal is only quash those administrative (bot/weblate) commits that were generated by the same action, usually close together. But if you see at generated history, even some migration commits (like 18.0, 17.0, 15.0, or 14.0) are lost. |
|
@robyf70 I’m suggesting one approach that should help keep the migration history clean. If you have another way to achieve the same result, that’s fine too. Otherwise, you can follow this approach: Remove the existing commits locally without pushing them, rerun the migration process to generate the proper commit history, and then cherry-pick your migration commit from this PR. After that, squash the administrative and bot/weblate commits as per the guidance and push again. |
Migrated to v19.0