Skip to content

[18.0][ADD] maintenance_equipment_tier_validation - #574

Open
smorita7749 wants to merge 1 commit into
OCA:18.0from
qrtl:18.0-add-maintenance-equipment-tier-validation
Open

smorita7749 wants to merge 1 commit into
OCA:18.0from
qrtl:18.0-add-maintenance-equipment-tier-validation

Conversation

@smorita7749

Copy link
Copy Markdown

@OCA-git-bot OCA-git-bot added series:18.0 mod:maintenance_equipment_tier_validation Module maintenance_equipment_tier_validation labels Jul 10, 2026
@smorita7749
smorita7749 marked this pull request as draft July 10, 2026 06:18
@smorita7749
smorita7749 force-pushed the 18.0-add-maintenance-equipment-tier-validation branch from 1851700 to 3aa8d6f Compare July 10, 2026 07:11
@smorita7749
smorita7749 marked this pull request as ready for review July 13, 2026 02:46
Comment thread maintenance_equipment_tier_validation/models/maintenance_equipment.py Outdated
Comment thread maintenance_equipment_tier_validation/__manifest__.py Outdated
@smorita7749
smorita7749 force-pushed the 18.0-add-maintenance-equipment-tier-validation branch 2 times, most recently from 70ac45c to b7e2711 Compare July 28, 2026 07:05
Comment thread oca_dependencies.txt Outdated
@smorita7749
smorita7749 force-pushed the 18.0-add-maintenance-equipment-tier-validation branch 3 times, most recently from db92215 to 88bb978 Compare July 28, 2026 08:08
@smorita7749
smorita7749 force-pushed the 18.0-add-maintenance-equipment-tier-validation branch from 88bb978 to 824e0d0 Compare August 26, 2026 03:28

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: LG

Minor points.

@@ -0,0 +1,4 @@
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
# Copyright 2026 Quartile
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@@ -0,0 +1,3 @@
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
# Copyright 2026 Quartile
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Comment thread README.md Outdated
[maintenance_equipment_sequence](maintenance_equipment_sequence/) | 18.0.1.0.0 | | Adds sequence to maintenance equipment defined in the equipment's category
[maintenance_equipment_status](maintenance_equipment_status/) | 18.0.1.0.0 | | Maintenance Equipment Status
[maintenance_equipment_tags](maintenance_equipment_tags/) | 18.0.1.0.0 | <a href='https://github.com/etobella'><img src='https://github.com/etobella.png' width='32' height='32' style='border-radius:50%;' alt='etobella'/></a> | Adds category tags to equipment
[maintenance_equipment_tier_validation](maintenance_equipment_tier_validation/) | 18.0.1.0.0 | | Support a tier validation process for maintenance equipment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change part of the PR?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.

@smorita7749
smorita7749 force-pushed the 18.0-add-maintenance-equipment-tier-validation branch from 824e0d0 to e27d462 Compare September 2, 2026 01:51

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants