[19.0][IMP] maintenance_plan: align next_maintenance_date with genera… - #593
Open
samirGuesmi wants to merge 1 commit into
Open
samirGuesmi wants to merge 1 commit into
samirGuesmi wants to merge 1 commit into
Conversation
…ted requests _compute_next_maintenance and _create_new_request computed the next date separately, which could cause inconsistencies. Centralize the logic in maintenance.plan with _get_next_maintenance_date(). Recompute when a request stage changes. Skip past occurrences and use the first date on or after today.
Member
Author
AnizR
approved these changes
Sep 11, 2026
AnizR
left a comment
AnizR
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM
- the refactor makes it a bit easier to read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
align next_maintenance_date with generated requests
_compute_next_maintenance and _create_new_request computed the next date separately, which could cause inconsistencies.
Centralize the logic in maintenance.plan with _get_next_maintenance_date(). Recompute when a request stage changes.
Skip past occurrences and use the first date on or after today.