HYRAX-2005, remove unused FONcByte.h and FONcByte.cc and the correspo… - #1417
Merged
Conversation
…nding affected files.
…y leaks when an exception occurs. 2) correct a typo for NDEBUG 3) Reduce potential memory leaks for scalar and array data.
…he possible leaking when an exception occurs.
…n other platforms and with h5dump. Verify this is the case. So update the file.
… the string array handling when the number of the element of the fastest changing dimension is 1.
…ively reduce the code complexity.
…umbers. Also update the testsuite. The original testing file contains wrong attribute values.
…the legacy HDF4 tests failed.
…o UseContiguousStorage since the chunk size is adjusted dynamically for many cases. Also remove the unused BytetoShort keys. 3) Also update the configure files.
jgallagher59701
approved these changes
Aug 10, 2026
jgallagher59701
left a comment
jgallagher59701
left a comment
Member
There was a problem hiding this comment.
Two suggestions, but if those don't make sense, it can be merged as is. Thanks.
…nitialization list.
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nding affected files.
Description
Reference ticket: HYRAX-2005
Clean up the source code files(*.cc and *.h) with the following:
Tasks