HYRAX-2222, for non-super chunk cases, release the buffer used by a c… - #1422
Conversation
…hunk after reading data of a dmrpp array.
|
|
|
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
Two comments, but neither prevents merging the code.
| return read_string_array(); | ||
|
|
||
| // Sonar cloud marks the following log vulnerable to injection attacks. So comment out for the time being. | ||
| #if 0 |
| virtual void release_chunk_buffer() | ||
| { | ||
| if (d_read_buffer_is_mine) | ||
| delete[] d_read_buffer; |
There was a problem hiding this comment.
This might be something we address in a future ticket. I wonder if Claude could provide suggestions WRT replacing the explicit memory management with unique pointers as private class members.
But, for now, lets keep this as it is since this works and the change Sonar is asking for is more of a maintainability change.
2 participants
…hunk after reading data of a dmrpp array.
Description
Reference ticket: HYRAX-2020
Release memory after reading the array variable data when the data storage is contiguous or only contains one chunk.
Otherwise, the memory of these variables will only be released right before the dmr object is destroyed.
Tasks