Skip to content

Bug: Prevent spurious powder consolidation following mesh refinement - #108

Merged
colemanjs merged 1 commit into
mainfrom
amr_consolidation_fixup
Sep 21, 2026
Merged

colemanjs merged 1 commit into
mainfrom
amr_consolidation_fixup

Conversation

@colemanjs

Copy link
Copy Markdown
Collaborator

After topology changes, field mapping can lead to small floating point differences. During coarsening, the solid fraction field alpha1 can become non-unary in the solid, which leads to:

  1. consolidation according to the previous model:
if (alpha1[celli] < 1)
{
    alpha3[celli] = 1.0;
}
  1. Fictitious latent heat release in the mapped solid.

NOTE: A better long term solution for energy conservation might be to make the enthalpy the authoritative quantity for field mapping.

@colemanjs
colemanjs requested a review from kincaidkc September 21, 2026 14:37
@colemanjs colemanjs self-assigned this Sep 21, 2026

@kincaidkc kincaidkc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I never used the powder model during my testing so never noticed this issue. Thanks for fixing.

@colemanjs
colemanjs merged commit 8314d3c into main Sep 21, 2026
1 check passed
@colemanjs
colemanjs deleted the amr_consolidation_fixup branch September 21, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants