BUG: Renewable Controller edge case - #568
Merged
Merged
Conversation
Collaborator
Author
|
I think there is an inconsistant default tolerance issue that is causing issues across platforms because the only reason I observed this issue is that the CI for #564 is failing, but works on my machine |
nkoukpaizan
approved these changes
Sep 4, 2026
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
A few minor comments.
Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the numerical conditioning of the REGCA and REECB algebraic equations and cleans up their documentation and tests.
Proposed changes
ILMAXcontinuation variable and compute current-circle capacity directly.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further Comments
This was contributing to some convergence failures when a particularly low-impedance fault is applied.