Initial mu configurability - #569
Closed
lukelowry wants to merge 2 commits into
Closed
Conversation
nkoukpaizan
reviewed
Sep 4, 2026
Comment on lines
+22
to
+28
| * @warning Process-wide setting; configure before constructing models or | ||
| * launching workers. | ||
| * | ||
| * @tparam RealT - real data type | ||
| */ | ||
| template <typename RealT> | ||
| inline constexpr RealT MU = 240.0; | ||
| inline RealT MU = DEFAULT_MU<RealT>; |
Collaborator
There was a problem hiding this comment.
I don't think we can merge this, even as a temporary solution. The provenance of the value used will be very hard to establish.
Collaborator
Author
There was a problem hiding this comment.
I cannot think of an alternative that would be a small change. I would love to have this for the purpose of the paper, but I see the issue.
Unless you have any ideas on how to do this safely, I will close this
Collaborator
There was a problem hiding this comment.
The ideas I have require widespread changes. We can close for now and keep tracking in #504.
lukelowry
force-pushed
the
lukel/mu-control-dev
branch
2 times, most recently
from
September 8, 2026 00:24
79ae81e to
dd96f51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an initial, intentionally small change to make the CommonMath smoothing scale runtime-configurable. PhasorDynamics studies can now set$\mu$ ) in a
mu(.solver.jsonfile, allowing parameter studies without rebuilding GridKit for every value.Proposed changes
muwith the existing240.0defaultmuto be positive and finiteChecklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
This is not the best long-term API for configuring$\mu$ at runtime, but without this, the results of our paper are very hard to reproduce without a development environment. For that reason, I would like to have this in before we do the first release.