Skip to content

Extract base conversion functions - #571

Open
lukelowry wants to merge 1 commit into
developfrom
lukel/mva-base-dev
Open

Extract base conversion functions#571
lukelowry wants to merge 1 commit into
developfrom
lukel/mva-base-dev

Conversation

@lukelowry

Copy link
Copy Markdown
Collaborator

Description

Consolidates PhasorDynamics component power-base conversion and consistently requires explicit component ratings instead of falling back to the system base.

Proposed changes

  • Add shared component-base storage and conversion helpers to Component.
  • Use the shared conversion across the affected machines, governors, converter, and controllers.
  • Require mva for REECB and Trate for GASTPTI and HYGOV.
  • Remove duplicated model-specific conversion helpers and storage.
  • Update the corresponding documentation and tests.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • Changelog changes are N/A; this is a focused cleanup of existing model implementations.

Further comments

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant