Classical Generator Updates and Completion - #572
Merged
Conversation
nkoukpaizan
approved these changes
Sep 7, 2026
…MakeLists.txt Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
Collaborator
Author
|
@nkoukpaizan As long as the CI passes then I agree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
GenClassicalto have recent conventions and implementation. Adds functionality to the signal ports, so governors, exciters, and stabilizers now connect to it the same way they connect to other machines.Proposed changes
GenClassicalInternalVariables/GenClassicalExternalVariablesandComponentSignalswithpmechandefdinputs and aspeedoutput.setPmech/setEp,bus_id_, and the deadexciter_signal/governor_signalinputs.DfDwsblock to the Enzyme Jacobian and link the signal libraries.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Could not be connected to controllers before this PR because we started governor and exciter integration with
Genrou