Skip to content

Move PowerElectronics models to a namespace uniformly - #576

Merged
nkoukpaizan merged 6 commits into
developfrom
nicholson/power-electronics-namespace
Sep 11, 2026
Merged

Move PowerElectronics models to a namespace uniformly#576
nkoukpaizan merged 6 commits into
developfrom
nicholson/power-electronics-namespace

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Description

This moves PowerElectronics models to a namespace uniformly.

Proposed changes

  • Relevant models that were straight in GridKit:: are now in GridKit::PowerElectronics.
  • This simplifies the older Circuit* and PowerElectronicsModel names
  • Updated tests and examples accordingly

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A] The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

I recommend ignoring whitespaces when reviewing.

@nkoukpaizan nkoukpaizan self-assigned this Sep 10, 2026

@abdourahmanbarry abdourahmanbarry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Comment thread examples/PowerElectronics/ExamplesHelper/SystemAssembler.hpp Outdated
Co-authored-by: abdourahmanbarry <153353767+abdourahmanbarry@users.noreply.github.com>
@nkoukpaizan
nkoukpaizan merged commit b66b7f4 into develop Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants