Skip to content

Fix IDA initial condition tol for fixed steps - #579

Merged
superwhiskers merged 1 commit into
developfrom
steven/fixed-step-ic
Sep 12, 2026
Merged

Fix IDA initial condition tol for fixed steps#579
superwhiskers merged 1 commit into
developfrom
steven/fixed-step-ic

Conversation

@Steven-Roberts

@Steven-Roberts Steven-Roberts commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes a bug where tolerances were too loose when fixed step IDA solved for consistent initial conditions. Adaptive IDA was unaffected.

Proposed changes

Adds missing IDASetNonlinConvCoefIC call.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

@superwhiskers superwhiskers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll merge this once this passes ci

@superwhiskers
superwhiskers merged commit 2835da0 into develop Sep 12, 2026
16 of 26 checks passed
@superwhiskers
superwhiskers deleted the steven/fixed-step-ic branch September 12, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants