Make batch connect script files executable - #951
Conversation
|
Thanks, I've just got to pull this down and ensure it works. |
|
Hey @Guflly, thanks for responding to the review feedback and for the thorough testing. You may have missed this but we recently published an AI policy on our main repository in OSC/ondemand#5646, and I wanted to get some info about your setup both for records and credit attribution, as well as to ensure that it is in line with our policy we established in that PR, which states
Before we continue reviewing this PR, would you mind answering the following questions?
|
What does this PR do?
Makes the default batch-connect script executable before starting it. Custom
run_scriptvalues and subclass overrides are left unchanged.Related issue
Fixes #948
Testing
bundle _2.7.2_ exec ruby -Itest -rminitest/autorun test/batch_connect/template_test.rbChecklist