Skip to content

Fix misleading validation-failure log message in AddPlayer/CreateNewA… #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SeanDuggan merged 1 commit into from
Sep 2, 2026
Merged

Fix misleading validation-failure log message in AddPlayer/CreateNewA… #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/servlets/admin/userManagement/AddPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,15 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
log.error("Invalid Addresses Detected");
errorMessage += "Invalid Addresses Detected";
} else if (!userValidate) {
log.error("JavaScript validation bypassed");
log.warn(
"Server-side user validation failed for new player (username length="
+ userName.length()
+ ", password length="
+ passWord.length()
+ ", address length="
+ userAddress.length()
+ "); expected: username 3-32 chars, password 8-512 chars, address <=128"
+ " chars");
errorMessage += "Invalid Request. Please try again";
} else {
log.debug("Class Not Found");
Expand Down
10 changes: 9 additions & 1 deletion src/main/java/servlets/admin/userManagement/CreateNewAdmin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,15 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
log.error("Invalid Addresses Detected");
errorMessage += "Invalid Addresses Detected";
} else if (!userValidate) {
log.error("JavaScript validation bypassed");
log.warn(
"Server-side user validation failed for new admin (username length="
+ userName.length()
+ ", password length="
+ passWord.length()
+ ", address length="
+ userAddress.length()
+ "); expected: username 3-32 chars, password 8-512 chars, address <=128"
+ " chars");
errorMessage += "Invalid Request. Please try again";
}
out.print(
Expand Down