Skip to content

OpenFOAM: a response row at the run's final time only; a utility refused as a utility - #20

Merged
dmitrat merged 4 commits into
mainfrom
fix/foam-walk-findings
Sep 27, 2026
Merged

dmitrat merged 4 commits into
mainfrom
fix/foam-walk-findings

Conversation

@dmitrat

@dmitrat dmitrat commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Findings of the WitSweep OpenFOAM walk on test and engine.

  • OpenFOAM 1.0.6 - a response file whose last row is not at the run's final time (the solver log's) is not reported: a function object that stopped writing before the run ended - a write interval that misses the end time, a timeEnd - left a stale value that was reported as the variant's response. The file is named in log.responses, which travels with the step logs, and in the node's log. An unknown final time checks nothing. The kit oracle (the forceCoeffs response-token test on the Windows kit) passes through the check.
  • OpenFOAM.Model 1.3.1 - a recipe whose application is an allow-listed utility (potentialFoam) was refused with "is not a solver name (a solver's name ends in 'Foam')", a reason that does not fit a name ending in 'Foam'; it is now refused as a utility and told where it belongs.
  • Sweep 2.0.5 - carries Model 1.3.1 (the host validates recipes with the Model its module bundles).

Tests: OpenFOAM 266 (+ the Windows kit oracle), Sweep 77.

Publish order after merge: OpenFOAM.Model, OpenFOAM, Sweep.

🤖 Generated with Claude Code

dmitrat and others added 4 commits September 27, 2026 07:51
… a utility

A recipe whose application was potentialFoam was refused with "is not a
solver name (a solver's name ends in 'Foam')" - a reason that does not
fit a name ending in 'Foam'. An allow-listed utility in the application's
place is now named for what it is and where it belongs; a name of no
known shape keeps the solver-name reason. OpenFOAM.Model 1.3.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…not reported

The extractor read the last row of every file in a function object's
latest time directory, whatever its time. A function object that stops
writing before the run ends - a write interval that misses the end time,
a timeEnd - left its last row at an earlier time, and that stale value
was reported as the variant's response. Given the run's final time (the
solver log's), a file whose last row is earlier is now left out, and a
sentence names it in log.responses beside the step logs, where it travels
with the logs, and in the node's log. An unknown final time checks
nothing. OpenFOAM 1.0.6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The host validates a case's recipe with the Model its module bundles; a
refusal it words must be the Model's current words.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmitrat
dmitrat merged commit ac90044 into main Sep 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant