Add a top-level omnyshell ide [path] command (v1.57.0) - #114
Merged
Merged
Conversation
The TUI IDE was only reachable from inside a session, as the `:ide` local
command — so editing a directory meant starting `omnyshell local .` first and
paying for a PTY shell you did not need. It is now a command of its own:
omnyshell ide # the current directory
omnyshell ide /path/to/project # or an explicit root (`~/…` is expanded)
Rather than duplicate the launch wiring, `:ide`'s AI-provider and
`command_shield` setup moves into a shared `runIdeApp()`, which both entry
points call; the root resolution `:ide` already had becomes the public
`resolveLocalIdeRoot()`. Passing no `input` stream lets `Terminal` own stdin
and raw mode itself, which is exactly what a standalone command needs — the
in-session path keeps forwarding the line editor's stdin as before.
`:ide` remains the way to edit a *remote* node's filesystem from
`omnyshell connect`; the new command is local-only. Argument errors are
reported before the TTY check, so a bad path is diagnosed as a bad path.
Also fixes an analyzer error in `IdeApp.run`: `inputSub` is a mutable local
captured by the listener closure, so the promotion from `inputSub!.pause()`
was invalidated by the `await` in the loop.
Ships as 1.57.0, which also covers the dependency bumps already staged in the
manifest (omnyhub ^1.7.0, uuid ^4.6.0), plus a formatter reflow of nine test
files.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The TUI IDE was only reachable from inside a session, as the
:idelocal command — so editing a directory meant startingomnyshell local .first and paying for a PTY shell you did not need.What
Rather than duplicate the launch wiring,
:ide's AI-provider andcommand_shieldsetup moves into a sharedrunIdeApp()that both entry points call, and the root resolution:idealready had becomes the publicresolveLocalIdeRoot(). Passing noinputstream letsTerminalown stdin and raw mode itself — what a standalone command needs; the in-session path keeps forwarding the line editor's stdin as before.:ideremains the way to edit a remote node's filesystem fromomnyshell connect; the new command is local-only. Argument errors are reported before the TTY check, so a bad path is diagnosed as a bad path.resolveLocalIdeRoot,runIdeApp,WorkspaceandLocalWorkspaceare exported fromomnyshell_client.dart, so an embedder can launch the IDE the way the CLI does.Also fixes an analyzer error in
IdeApp.run:inputSubis a mutable local captured by the listener closure, so the promotion frominputSub!.pause()was invalidated by theawaitin the loop.Release
Ships as 1.57.0 (
pubspec.yaml+omnyShellVersion), which also covers the dependency bumps already staged in the manifest (omnyhub^1.7.0, uuid^4.6.0). Included as separate noise: adart formatreflow of nine test files.Verification
dart analyze .→ no issues; touched files formatted.dart test test/unit→ 676 passed (9 skipped, pre-existing).omnyshell --helplistside;help ideshows usage + examples;--versionprints 1.57.0.ide /nope→error: omnyshell ide: no such directory: /nope(exit 1);ide a b→takes at most one directory argument(exit 1).Not verified: launching the full-screen IDE itself — in the dev sandbox the Dart VM reports
stdout.hasTerminal == falseeven under a real pty, so the TTY guard always trips (same limitation forlocalanddashboard). Worth a manualomnyshell idein a real terminal; the regression risk is concentrated in:idenow routing through the sharedrunIdeApp.🤖 Generated with Claude Code