Peterson implement improvements in 404 page - #2962
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ManasaViswanadhapalli
left a comment
There was a problem hiding this comment.
I have tested and it is working as expected.
https://www.loom.com/share/60f61fdcc6494e72ad54e9763ba9619f?sid=ce7d563a-dbbc-4617-90a3-9747ac3bd93b
honglinchen0524
left a comment
There was a problem hiding this comment.
The error pages only shows up if the first path segment is invalid. If the first path segment is valid, it does not takes me to the error page(see first video).
Also it does not work for profile page(see second video).
PR2962.mp4
PR.mp4
8bfd455
|
Fix works well when the 404 page is reached, however routes may need to be looked at as dashboard and timelog screens do not redirect to 404 page but teamlocations works. PR.2962.mp4PR.2962.2.mp4 |
Peter-Nie2003
left a comment
There was a problem hiding this comment.
The web work as expected, great job!
PR2962.mov
AurHubertMax
left a comment
There was a problem hiding this comment.
Tested page where user is not logged in, along with volunteer, admin, and owner accounts. Page not found works as expected. Links in the page not found page also works as expected.
z.PR.2962.proof.1.mp4
There was a problem hiding this comment.
Issue: While http://localhost:3000/dashboard and http://localhost:3000/kjwhdg work as expected, http://localhost:3000/dashboard/wjhsdgc is also accessible, which is incorrect. sometimes image is not displayed.
Suggestion: Ensure proper route handling so that undefined subroutes under /dashboard return the correct error response instead of loading.
https://drive.google.com/file/d/1G-3OzDHtUiXPFS0kAORf-YujrLF3pKDD/view?usp=sharing
Uploading 2962.mov…
|
I've tested the pull request, and the functionality is working as expected—logged-in users see two links, while logged-out users see only one. However, I found an issue where the display image doesn't load correctly when there are multiple path separators (/) in the URL. Additionally, when a user submits a report, the modal opens as expected, and the URL updates to http://localhost:3000/dashboard?openModalReport. However, even after closing the modal or submitting the report, if the page is reloaded, the modal opens again. This seems to be due to the query parameter still being present in the URL after the modal is closed.
|
HSP24SCM69K
left a comment
There was a problem hiding this comment.
Reviewed and tested the 404 Error Page improvements for both logged-in and logged-out users.
Functionality: All redirects are working as expected, with logged-in users correctly seeing options for the dashboard and suggestion modal, while logged-out users are redirected to the login page.
UI & User Experience: The design is clean, intuitive, and responsive, ensuring smooth navigation.
Performance: No errors were encountered, and all features function as intended.


linh2020
left a comment
There was a problem hiding this comment.
I have checked out the PR branch, installed dependencies, and cleared the cache. I logged in as both a regular and admin user and verified the error page behavior for non-existent routes. Everything works as expected — the 404 page displays the correct links based on login state, renders correctly in both light and dark modes, and no console errors appear. I also tested nested routes and verified that the modal behaves as expected.























This PR has conflicts that I couldn't resolve because the button at the bottom of the page was disabled. I needed to fix the bugs in this PR, so I decided to create a new PR with the bugs fixed and without the conflict error. After opening the new PR, I decided to close the old PR.
To test the new PR that implements the 404 page and does not have the bugs present in this PR, click this link: #3286