Jaden taking over for Peterson: Fixed bug in badge management (DONE Jaden) - #3631
Open
peterson337 wants to merge 16 commits into
Open
Jaden taking over for Peterson: Fixed bug in badge management (DONE Jaden)#3631peterson337 wants to merge 16 commits into
peterson337 wants to merge 16 commits into
Conversation
peterson337
added
the
do not review
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
peterson337
removed
the
do not review
looks good
|
1709abhishek
self-requested a review
June 14, 2025 03:17
1709abhishek
approved these changes
Jun 14, 2025
Contributor
|
Working as expected |
akshaygadsing
approved these changes
Jul 13, 2025
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…es with installed equivalents
formatDate in AddTaskModal and formatDate/parseDate in EditTaskModal were only used as DayPickerInput props - now unused after removing that component. DateUtils was also undefined (came from react-day-picker). Fixed const declaration appearing between import statements in SetupProfileUserEntry.
- PeopleReport: remove no-op toString() call, convert to early return - ImportTask: remove redundant onClick from inner span (parent Button handles it) - AddTaskModal: remove unused dateWarning state, Row/Col imports, duplicate react/messages imports, and unused DUE_DATE message constant
react-beautiful-dnd is in package.json; @hello-pangea/dnd is not, so the substitution was breaking the Netlify build.
All swapped imports (react-html-parser, d3, react-day-picker, react-beautiful-dnd, react-input-range) are in package.json and installed on Netlify. Only the core badge management bug fix should be in this PR.
…adge-management-error
Jaden300
changed the title
kzou55
previously approved these changes
Jul 27, 2026
iAbhi001
self-requested a review
July 28, 2026 01:12
iAbhi001
previously approved these changes
Jul 28, 2026
iAbhi001
left a comment
iAbhi001
left a comment
There was a problem hiding this comment.
Tested locally on branch pr-3631:
Navigated to Badge Management and clicked "Edit" on multiple badges.
Verified that the Edit Badge form/modal opens without throwing null imageUrl console errors.
Checked browser console for crashes or regressions.
Everything looks good! LGTM 🚀
DeepighaJ
requested changes
Jul 28, 2026
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
Tested the PR. The functionality works as expected , no errors where seen and edit/update works as expected.
Issue:
Under dark mode, on hover the dark mode needs improvement. User cannot see when the content properly when highlighting the rows.
Update works successfully
- Add BadgeDevelopmentTable.module.css with scoped tableDark hover styles - Apply styles.tableDark in dark mode instead of plain dark-mode CSS string
- Toggle filter button label between Add Filters and Remove Filters - Apply dark mode classes to all filter label text - Move filter section layout and button box-shadow to CSS module - Fix input and dropdown backgrounds in dark mode - Fix placeholder text color via ::placeholder rule - Fix text selection visibility in dark mode via ::selection rule
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jaden taking over for Peterson: Fixed bug in badge management (DONE Jaden) #3631
Description
This PR has been opened to fix the bug in Badge Management.
Related PRS (if any):
None
Main changes explained:
The BadgeDevelopmentTable.jsx component has been modified to fix the bug.
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Before my fix:
After my fix
Note:
None