Handika: Create a People Report solution for when people have more than 20 tasks. - #5405
Open
handikaharianto wants to merge 48 commits into
Open
Handika: Create a People Report solution for when people have more than 20 tasks.#5405handikaharianto wants to merge 48 commits into
handikaharianto wants to merge 48 commits into
Conversation
…-report-solution-for-large-tasks
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…eport details page
…er in larger screen
…-report-solution-for-large-tasks
The legend table in CompletedTasksPieChart is currently capped with a fixed 60vh/80vh CSS rule. On screens >= 2000px there is significant unused vertical space inside the parent .stats block. This spec describes measuring the available height in PeopleReport (stats.height - metrics.height - PeopleTasksPieChart.height) and passing it down to CompletedTasksPieChart as a prop, with the CSS rules remaining as the fallback for screens below 2000px and the brief moment before the first ResizeObserver measurement. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…d update people report's styling
handikaharianto
added
the
High Priority - Please Review First
|
handikaharianto
removed
the
High Priority - Please Review First
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PRS (if any):
This frontend PR is related to the #4635 .
Main changes explained:
Tasks With Completed Hourschart.CompletedTasksPieChart.How to test:
handika/people-report-solution-for-large-tasksnpm installandnpm run start:localto run this PR locallyTasks With Completed Hourstable properly handles large number of completed tasks.Tasks With Completed Hourstable displays an empty state when there is no data to display.Note:
None