Skip to content

fix(items): optimize inventory checks and fix free space calculation#86

Open
theEvilReaper wants to merge 2 commits into
developfrom
fix/items-free-space-and-caching
Open

fix(items): optimize inventory checks and fix free space calculation#86
theEvilReaper wants to merge 2 commits into
developfrom
fix/items-free-space-and-caching

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

This PR refactors the Items utility class to improve performance and correctness when analyzing player inventories.

Previously, getAmountFromItem and getFreeSpace queried the inventory array repeatedly during loop iterations, creating unnecessary overhead. Additionally, getFreeSpace assumed all non-empty slots had a maximum stack size of 64, which led to incorrect free space calculations for items with custom stack limits such as Ender Pearls or unstackable tools and armor

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Jul 22, 2026
@theEvilReaper theEvilReaper added the enhancement New feature or request label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant